Protocol: renew device certificate if it is not valid #53
+72
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 39.98% 39.65% -0.34%
==========================================
Files 7 7
Lines 1158 1203 +45
==========================================
+ Hits 463 477 +14
- Misses 592 623 +31
Partials 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The device certificate was obtained only once, during the first connection. However, certificates may change over time (e.g. by substituting an expired one with a valid one). Obtain a new certificate if the old one is not valid anymore. As paho mqtt client does not expose TLS errors upon reconnection, a custom open connection function was added. Signed-off-by: Arnaldo Cesco <[email protected]>
Remove always-nil error from initializeMqttClient function signature Signed-off-by: Arnaldo Cesco <[email protected]>
rbino
approved these changes
Sep 2, 2022
matt-mazzucato
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device certificate was obtained only once, during the first connection. However, certificates may change over time
(e.g. by substituting an expired one with a valid one). Obtain a new certificate if the old one is not valid anymore.
As paho mqtt client does not expose TLS errors upon reconnection, a custom open connection function was added.
See #11.